Skip to content

fs: fix glob case-sensitivity inconsistencies #63446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
louiellan wants to merge 1 commit into from
+54 −1
Closed

fs: fix glob case-sensitivity inconsistencies #63446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/fs/glob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function createMatcher(pattern, options = kEmptyObject) {
nocomment: true,
optimizationLevel: 2,
platform: process.platform,
nocaseMagicOnly: true,
nocaseMagicOnly: (!isWindows && !isMacOS),
...options,
};
return new (lazyMinimatch().Minimatch)(pattern, opts);
Expand Down
53 changes: 53 additions & 0 deletions test/parallel/test-fs-glob.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@
test(pattern, async () => {
const actual = (await promisified(pattern, { cwd: fixtureDir })).sort();
const normalized = expected.filter(Boolean).map((item) => item.replaceAll('/', sep)).sort();
assert.deepStrictEqual(actual, normalized);

Check failure on line 334 in test/parallel/test-fs-glob.mjs

View workflow job for this annotation

GitHub Actions / test-macOS 

--- stdout ---
Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:331:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/node/node/node/test/parallel/test-fs-glob.mjs:334:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:341:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/node/node/node/test/parallel/test-fs-glob.mjs:344:14)
    at Test.runInAsyncScope (node:async_hooks:226:14)
    at Test.run (node:internal/test_runner/test:1366:25)
    at Suite.processPendingSubtests (node:internal/test_runner/test:946:18)
    at Test.postRun (node:internal/test_runner/test:1506:19)
    at Test.run (node:internal/test_runner/test:1431:12)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:351:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/node/node/node/test/parallel/test-fs-glob.mjs:356:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:364:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/node/node/node/test/parallel/test-fs-glob.mjs:367:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:374:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestC

Check failure on line 334 in test/parallel/test-fs-glob.mjs

View workflow job for this annotation

GitHub Actions / x86_64-darwin: with shared libraries 

--- stdout ---
Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:331:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:334:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:341:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:344:14)
    at Test.runInAsyncScope (node:async_hooks:226:14)
    at Test.run (node:internal/test_runner/test:1366:25)
    at Suite.processPendingSubtests (node:internal/test_runner/test:946:18)
    at Test.postRun (node:internal/test_runner/test:1506:19)
    at Test.run (node:internal/test_runner/test:1431:12)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:351:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:356:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:364:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:367:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:374:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/

Check failure on line 334 in test/parallel/test-fs-glob.mjs

View workflow job for this annotation

GitHub Actions / aarch64-darwin: with shared libraries 

--- stdout ---
Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:331:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:334:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:341:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:344:14)
    at Test.runInAsyncScope (node:async_hooks:226:14)
    at Test.run (node:internal/test_runner/test:1366:25)
    at Suite.processPendingSubtests (node:internal/test_runner/test:946:18)
    at Test.postRun (node:internal/test_runner/test:1506:19)
    at Test.run (node:internal/test_runner/test:1431:12)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:351:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:356:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:364:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c'
- ]

    at TestContext.<anonymous> (file:///Users/runner/work/_temp/node-v27.0.0-nightly2026-06-0250d165aeba-slim/test/parallel/test-fs-glob.mjs:367:14)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:946:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [],
  expected: [Array],
  operator: 'deepStrictEqual',
  diff: 'simple'
}

Test failure: 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**'
Location: test/parallel/test-fs-glob.mjs:374:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
-   'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/
});
}
});
Expand Down Expand Up @@ -484,6 +484,59 @@
[ 'a/**', [ '*' ], [] ],
[ 'a/**', [ '**' ], [] ],
[ 'a/**', [ 'a/**' ], [] ],
...((common.isWindows || common.isMacOS) ?
// on Windows or MacOS
[
['a/b', ['A/B'], []],
['a/b*', ['A/B'], ['a/bc']],
['A*/B', ['A/B'], []],
['a*/B', ['A/B'], []],
['a*/b', ['A/B'], []],

['A/B', ['a/b'], []],
['A/B*', ['a/b'], ['a/bc']],
['A*/B', ['a/b'], []],
['a*/B', ['a/b'], []],
['A*/b', ['a/b'], []],

['a/b', ['A/B*'], []],
['a/b*', ['A/B*'], []],
['A*/B', ['A/B*'], []],
['a*/B', ['A/B*'], []],
['a*/b', ['A/B*'], []],

['A/B', ['a/b*'], []],
['A/B*', ['a/b*'], []],
['A*/B', ['a/b*'], []],
['a*/B', ['a/b*'], []],
['A*/b', ['a/b*'], []],

['a/b', ['A*/B'], []],
['a/b*', ['A*/B'], ['a/bc']],
['A*/B', ['A*/B'], []],
['a*/B', ['A*/B'], []],
['a*/b', ['A*/B'], []],

['A/B', ['a*/b'], []],
['A/B*', ['a*/b'], ['a/bc']],
['A*/B', ['a*/b'], []],
['a*/B', ['a*/b'], []],
['A*/b', ['a*/b'], []],

['a/b', ['A/{B,C}'], []],
['a/b*', ['A/{B,C}'], ['a/bc']],
['A*/B', ['A/{B,C}'], []],
['a*/B', ['A/{B,C}'], []],
['a*/b', ['A/{B,C}'], []],

['A/B', ['a/{b,c}'], []],
['A/B*', ['a/{b,c}'], ['a/bc']],
['A*/B', ['a/{b,c}'], []],
['a*/B', ['a/{b,c}'], []],
['A*/b', ['a/{b,c}'], []],

] : []
),
];

describe('globSync - exclude', function() {
Expand Down
Loading