feat(ui): improve partner grid layout on download page#8750
feat(ui): improve partner grid layout on download page#8750Shubham-1068 wants to merge 4 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
This PR updates the Downloads page partner logo layout to center the partner grid and improve visual alignment/consistency across screen sizes, addressing #8749.
Changes:
- Updated the
.largepartner layout from an auto-fill, full-width-stretching grid to an auto-fit grid with bounded column widths. - Centered the resulting grid tracks within the container and adjusted spacing between items.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
For context, the reason why it renders like that is because we only have 3 partners atm, whereas the grid was designed for up to 4, but wasn't designed to account for the fact we could have less than 4. |
This comment was marked as off-topic.
This comment was marked as off-topic.
ovflowd
left a comment
There was a problem hiding this comment.
I have the feeling you accidentally added unrelated changes to this PR.
|
@ovflowd Actually when i ran the test command locally before pushing the changes it was failing at that time, but it was a local issue and now i see that i accidentally pushed those changes too. So i am reverting those changes while sticking to the original issue i.e, only the grid layout improvements. Sorry for this confusion. |
d29fcc8 to
adddbc1
Compare
|
@ovflowd i have made the required changes kindly review it |
|
Lighthouse Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8750 +/- ##
=======================================
Coverage 75.27% 75.27%
=======================================
Files 105 105
Lines 9242 9247 +5
Branches 326 328 +2
=======================================
+ Hits 6957 6961 +4
- Misses 2283 2284 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
…ss on small screens too
|
@ovflowd Hey, do I need to make any other changes or are we good to go ? If everything looks good, could you approve the workflow runs and merge it when you get a chance ? |
|
@ovflowd Everything is clear on my side can you please merge these changes when you get a chance ? |
bjohansebas
left a comment
There was a problem hiding this comment.
LGTM. it’s curious, i remember it used to take up all the space. Not sure when that stopped happening
Description
Centered the partner logos in the download page’s partner section by adjusting the grid layout for improved visual alignment and consistency.
Validation
Related Issues
Fixes #8749
Before changes:
After changes:
Files Changed
Code Changed
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.