fix: resolve symlink in workspace node_modules when --workspace flag …#9159
Open
yetanotheraryan wants to merge 1 commit intonpm:latestfrom
Open
fix: resolve symlink in workspace node_modules when --workspace flag …#9159yetanotheraryan wants to merge 1 commit intonpm:latestfrom
yetanotheraryan wants to merge 1 commit intonpm:latestfrom
Conversation
Author
|
@owlstronaut Please review and let me know if anything needs to be changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Fixes workspace-targeted npm link so the symlink is created inside the selected workspace instead of being reified at the project root.
This is a minimal command-level change in npm link for the --workspace + args case. It preserves existing non-workspace behavior and adds regression coverage for the workspace install location.
References
Fixes #9115