Initialize ESPProvisioningProvider with the proper realm (from URL or…#56
Open
ebariaux wants to merge 1 commit into
Open
Initialize ESPProvisioningProvider with the proper realm (from URL or…#56ebariaux wants to merge 1 commit into
ebariaux wants to merge 1 commit into
Conversation
MartinaeyNL
requested changes
May 26, 2026
Member
There was a problem hiding this comment.
@ebariaux Me and @dominiquekleeven discussed on this "constants" approach, but agreed to not to go for this. 😅
My opinion was that the ESPProvisionProvider itself shouldn't be "aware that realms exist".
Instead, by including the realm in the provisionDevice payload itself, similar to the accessToken,
we only make the provider "realm aware" for this single API request the provider makes.
Alongside that, I think it'd be important for apps to work in multiple realms.
Because now it is locked into a single realm per app.
I'm happy to call if you'd like to discuss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… preferences)