OCPCLOUD-3359: Add component names and manifestSubstitutions to CAPI revisions

[mdbooth]

Allows a revision to contain substitution variables which will be passed to envsubst when rendering manifests. The initial purpose of this is substitution of cluster-wide Post Quantum Cryptography settings.

Also adds a name field to components to make it easier to understand what the installer is rendering for support and debugging.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@mdbooth: This pull request references OCPCLOUD-3359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @mdbooth! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 311fb49c-a162-486c-bcae-1d9cd67dd4e7

📥 Commits

Reviewing files that changed from the base of the PR and between 96f1f5a and 55afea3.

⛔ Files ignored due to path filters (3)

• openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**
• operator/v1alpha1/zz_generated.crd-manifests/0000_30_cluster-api_01_clusterapis.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1alpha1/zz_generated.featuregated-crd-manifests/clusterapis.operator.openshift.io/ClusterAPIMachineManagement.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**

📒 Files selected for processing (5)

• operator/v1alpha1/tests/clusterapis.operator.openshift.io/ClusterAPIMachineManagement.yaml
• operator/v1alpha1/types_clusterapi.go
• operator/v1alpha1/zz_generated.deepcopy.go
• operator/v1alpha1/zz_generated.swagger_doc_generated.go
• payload-manifests/crds/0000_30_cluster-api_01_clusterapis.crd.yaml

---

📝 Walkthrough

Walkthrough

This PR extends the ClusterAPI operator types to support manifest substitutions and component naming. The changes add a new ManifestSubstitutions field to store envsubst-style key/value pairs applied during manifest rendering, and a new Name field to ClusterAPIInstallerComponent for human-readable identification. New validation rules enforce specific formatting for substitution keys (variable-name format) and component names (alphanumerics and hyphens). Auto-generated code for deep-copy operations and Swagger documentation is updated accordingly. Test cases validate the new formatting requirements and error handling for missing required fields.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@mdbooth: This pull request references OCPCLOUD-3359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Allows a revision to contain substitution variables which will be passed to envsubst when rendering manifests. The initial purpose of this is substitution of cluster-wide Post Quantum Cryptography settings.

Also adds a name field to components to make it easier to understand what the installer is rendering for support and debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mdbooth]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[JoelSpeed]

/test verify-hypershift-integration

[qodo-code-review]

PR-Agent: could not fine a component named verify-hypershift-integration in a supported language in this PR.

[JoelSpeed]

/test verify-hypershift-integration

[JoelSpeed]

/test verify-hypershift-integration

[qodo-code-review]

Generating tests for 'verify-hypershift-integration' ✏️️

Work in progress ...

[openshift-ci]

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	55afea3	link	false	/test verify-hypershift-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.