USHIFT-6949: Remove external cAdvisor exporter from Ansible

[sjug]

Container metrics are now collected from the kubelet's /metrics/cadvisor endpoint, so the standalone cAdvisor exporter is no longer needed.

Summary by CodeRabbit

• Documentation

  • Updated prerequisites documentation to reflect changes to monitoring tools used for capturing system performance metrics.

• Chores

  • Removed a monitoring component from infrastructure setup.
  • Removed associated firewall port access rules.
  • Removed related monitoring metrics configuration.
  • Removed component service definitions and installation procedures.

[openshift-ci-robot]

@sjug: This pull request references USHIFT-6949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Container metrics are now collected from the kubelet's /metrics/cadvisor endpoint, so the standalone cAdvisor exporter is no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bf9362c1-36e5-4a83-ae2c-5560457b591a

📥 Commits

Reviewing files that changed from the base of the PR and between 9a9d010 and bfac7e0.

📒 Files selected for processing (7)

• ansible/README.md
• ansible/roles/configure-firewall/defaults/main.yml
• ansible/roles/install-logging-exporters/defaults/main.yml
• ansible/roles/install-logging-exporters/tasks/main.yml
• ansible/roles/install-logging-exporters/templates/cadvisor.service.j2
• ansible/roles/install-logging/templates/prometheus.yml.j2
• ansible/roles/microshift-start/tasks/main.yml

💤 Files with no reviewable changes (6)

• ansible/roles/install-logging-exporters/templates/cadvisor.service.j2
• ansible/roles/install-logging-exporters/defaults/main.yml
• ansible/roles/configure-firewall/defaults/main.yml
• ansible/roles/install-logging-exporters/tasks/main.yml
• ansible/roles/microshift-start/tasks/main.yml
• ansible/roles/install-logging/templates/prometheus.yml.j2

---

Walkthrough

This PR removes cAdvisor from the monitoring infrastructure by eliminating related configuration defaults, installation tasks, systemd templates, Prometheus scrape jobs, firewall rules, and prerequisite documentation.

Changes

cAdvisor Removal

Layer / File(s)	Summary
Documentation ansible/README.md	Prerequisites updated to remove cAdvisor; only Prometheus and process-exporter listed.
Configuration Defaults ansible/roles/install-logging-exporters/defaults/main.yml	Removed cadvisor_external, cadvisor_url, and cadvisor_checksum variables.
Firewall Rules ansible/roles/configure-firewall/defaults/main.yml	Removed 8082/tcp port entry (cAdvisor's port) from allowed TCP ports.
Service Installation ansible/roles/install-logging-exporters/tasks/main.yml	Removed conditional block for downloading cAdvisor binary, templating systemd unit, and starting/enabling cAdvisor service.
Service Template ansible/roles/install-logging-exporters/templates/cadvisor.service.j2	Removed entire systemd unit template for cAdvisor service.
Monitoring Configuration ansible/roles/install-logging/templates/prometheus.yml.j2	Removed cAdvisor scrape job from Prometheus configuration.
Health Checks ansible/roles/microshift-start/tasks/main.yml	Removed task that checked for cAdvisor binary presence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: removing the external cAdvisor exporter from Ansible configuration across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR contains only Ansible configuration and documentation changes. No Ginkgo test files are modified, so the test naming check is not applicable.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test quality is not applicable. PR contains only Ansible configuration changes with no Go test files.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. All changes are Ansible configuration files (YAML, templates, markdown). The MicroShift Test Compatibility check only applies when new tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Custom check is not applicable. PR contains only Ansible configuration/playbook changes with no new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only removes cAdvisor Ansible deployment code. No new deployment manifests, operator code, or scheduling constraints are introduced. Check applies to additions/modifications, not removals.
Ote Binary Stdout Contract	✅ Passed	Check not applicable. PR modifies only Ansible configs and templates (YAML/MD/J2 files), containing no Go code, test files, or OTE binary processes that could violate stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR contains no Ginkgo e2e tests. All changes are Ansible configuration files (YAML, Jinja2 templates, markdown). The custom check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@sjug: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ggiguash]

/lgtm
/verified by @sjug

[openshift-ci-robot]

@ggiguash: This PR has been marked as verified by @sjug.

Details

In response to this:

/lgtm
/verified by @sjug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment