[WIP] Fix windows developer doc.#4227
Open
rasapala wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows developer documentation to correct the example command used when passing optional parameters during the windows_build.bat compilation step.
Changes:
- Fix the optional-arguments example to call
windows_build.bat(instead ofwindows_install_build_dependencies.bat) in the compile section.
Comments suppressed due to low confidence (1)
docs/windows_developer_guide.md:85
- The
--integrityargument is documented as "flag to 0 or 1", butwindows_build.battreats it as a presence/absence switch (IF "%~4"=="--integrity"). Please update the description to reflect that no numeric value is passed (and clarify what integrity checks/config it enables).
windows_build.bat my_dir_on_c --with_python --with_tests --integrity
[arg1] This way you can change default dependency location directory to c:\my_dir_on_c
[arg2] --with_python - this will build the ovms.exe with python dependency and support for python chat templates for GENAI LLM
[arg3] --with_tests - this will also build ovms_test.exe target
[arg4] --integrity - Add the compilation integrity flag to 0 or 1 - set the additional integritycheck compilation flag when compiling dependencies
</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
windows docs issues.
🧪 Checklist
``