Skip to content

improve: deprecate instance based Mappers.fromOwnerReferences #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csviri merged 2 commits into from
May 20, 2026
+8 −0
Merged

improve: deprecate instance based Mappers.fromOwnerReferences #3365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1e1ca2
improve: deprecate instance based Mappers.fromOwnerReferences
csviri May 19, 2026
8e48dbb
wip
csviri May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...e/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/Mappers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,19 @@ public static <T extends HasMetadata> SecondaryToPrimaryMapper<T> fromOwnerRefer
clusterScoped);
}

/**
* @deprecated use {@link #fromOwnerReferences(Class)}
*/
@Deprecated(forRemoval = true)
public static <T extends HasMetadata> SecondaryToPrimaryMapper<T> fromOwnerReferences(
HasMetadata primaryResource) {
return fromOwnerReferences(primaryResource, false);
}

Comment on lines 89 to 98
Copy link
Copy Markdown
Collaborator

@xstefank xstefank May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I also think that all deprecations should point to replacements or explain why the method is being dropped.

Copy link
Copy Markdown
Collaborator Author

@csviri csviri May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, added javadoc to the alternative

/**
* @deprecated use {@link #fromOwnerReferences(Class,boolean)}
*/
@Deprecated(forRemoval = true)
public static <T extends HasMetadata> SecondaryToPrimaryMapper<T> fromOwnerReferences(
HasMetadata primaryResource, boolean clusterScoped) {
return fromOwnerReferences(
Expand Down
Loading