Skip to content

Change JUnit dependency scope from compile to scope#666

Merged
jonesbusy merged 1 commit intooras-project:mainfrom
ThomasVitale:gh-665
Apr 2, 2026
Merged

Change JUnit dependency scope from compile to scope#666
jonesbusy merged 1 commit intooras-project:mainfrom
ThomasVitale:gh-665

Conversation

@ThomasVitale
Copy link
Copy Markdown
Contributor

Description

The org.junit.jupiter:junit-jupiter-params dependency was mistakenly declared with compile scope, resulting in it being included in the final production artifact published to Maven Central. I fixed it by declaring it with test scope.

Fixes gh-665

Testing done

I ran the entire test suite and it succeeded.

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

Fixes oras-projectgh-665

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale ThomasVitale requested a review from jonesbusy as a code owner April 1, 2026 21:42
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.98%. Comparing base (29848ed) to head (70948d9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #666      +/-   ##
============================================
+ Coverage     86.43%   86.98%   +0.55%     
  Complexity      937      937              
============================================
  Files            43       43              
  Lines          2904     2904              
  Branches        364      364              
============================================
+ Hits           2510     2526      +16     
+ Misses          234      218      -16     
  Partials        160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy added the bug Something isn't working label Apr 2, 2026
@jonesbusy
Copy link
Copy Markdown
Collaborator

Thanks!

@jonesbusy jonesbusy merged commit d07d3c2 into oras-project:main Apr 2, 2026
13 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JUnit mistakenly included as production dependency instead of test

2 participants