Add source cell for disks, with side modal#3214
Draft
charliepark wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "source" cell to each row in the Disks table, and to each Instance's "Storage" tab.
For each of those locations, it provides a side modal with more info on the source disk / snapshot / image.
(In the Disk sidemodal, the source cell is not a link, to prevent stacking of side modals. This follows the pattern on #3158.)
I don't think "visibility" is the right label there on the image detail sidemodal. That comes from the general concept of the images where a project image can be promoted to have a silo-level "visibility". "Scope" feels better to me than "visibility". "Availability"? Something else?
I also toyed with an earlier iteration where there was a badge indicating the source type, but that seemed to make the cell a bit too wide, and I think since the user can click on the source name and get more info on the source type, the badge isn't essential. Here's what it looked like, though (note this was before I had the side modal link working):
Closes #2057