feat(Table): separate sticky and pinned styles#12316
feat(Table): separate sticky and pinned styles#12316kmcfaul wants to merge 2 commits intopatternfly:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe changes add a sticky header feature to the Table component by introducing an Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12316.surge.sh A11y report: https://pf-react-pr-12316-a11y.surge.sh |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/react-table/src/components/Table/Thead.tsx (1)
82-82: Remove debug comment.The commented
console.logshould be removed before merging.🧹 Proposed fix
const observer = new IntersectionObserver( ([entry]) => { - // console.log(scrollRoot, entry, entry.intersectionRatio); setIsPinned(entry.intersectionRatio < PINNED_INTERSECTION_RATIO); },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-table/src/components/Table/Thead.tsx` at line 82, Remove the debug comment "console.log(scrollRoot, entry, entry.intersectionRatio);" from the Table Thead component (Thead.tsx) so no leftover debug logging remains; locate the line within the intersection/observer logic where scrollRoot, entry, and entry.intersectionRatio are referenced and delete the commented console.log statement.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/react-table/src/components/Table/Thead.tsx`:
- Line 82: Remove the debug comment "console.log(scrollRoot, entry,
entry.intersectionRatio);" from the Table Thead component (Thead.tsx) so no
leftover debug logging remains; locate the line within the intersection/observer
logic where scrollRoot, entry, and entry.intersectionRatio are referenced and
delete the commented console.log statement.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4660fa05-ac78-4661-ba18-0fbdaf40d193
📒 Files selected for processing (2)
packages/react-table/src/components/Table/Table.tsxpackages/react-table/src/components/Table/Thead.tsx
73590e1 to
de46073
Compare
Testing out different methods of applying additional sticky styling only when the scroll has moved the element from the top of its container.
Summary by CodeRabbit