Skip to content

feat(icon): apply rh-standard styling and add opt-out #12320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kmcfaul wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(icon): apply rh-standard styling and add opt-out #12320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e604e9a
feat(icon): apply rh-standard styling and add opt-out
kmcfaul Apr 6, 2026
278cbbe
bump core ver
kmcfaul Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"tslib": "^2.8.1"
},
"devDependencies": {
"@patternfly/patternfly": "6.5.0-prerelease.62",
"@patternfly/patternfly": "6.5.0-prerelease.65",
"case-anything": "^3.1.2",
"css": "^3.0.0",
"fs-extra": "^11.3.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"test:a11y": "patternfly-a11y --config patternfly-a11y.config"
},
"dependencies": {
"@patternfly/patternfly": "6.5.0-prerelease.62",
"@patternfly/patternfly": "6.5.0-prerelease.65",
"@patternfly/react-charts": "workspace:^",
"@patternfly/react-code-editor": "workspace:^",
"@patternfly/react-core": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@fortawesome/free-brands-svg-icons": "^5.15.4",
"@fortawesome/free-regular-svg-icons": "^5.15.4",
"@fortawesome/free-solid-svg-icons": "^5.15.4",
"@patternfly/patternfly": "6.5.0-prerelease.62",
"@patternfly/patternfly": "6.5.0-prerelease.65",
"@rhds/icons": "^2.1.0",
"fs-extra": "^11.3.3",
"tslib": "^2.8.1"
Expand Down
537 changes: 537 additions & 0 deletions packages/react-icons/scripts/icons/rhIconsStandard.mjs
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 14 additions & 2 deletions packages/react-icons/src/createIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ export interface SVGIconProps extends Omit<React.HTMLProps<SVGElement>, 'ref'> {
className?: string;
/* Indicates the icon should render using alternate svg data for unified theme */
set?: 'default' | 'rh-ui';
/** Applicable to RH standard icons only. Indicates the icon should render without the standard set styling. */
noStandardSetStyling?: boolean;
}

let currentId = 0;
Expand Down Expand Up @@ -70,12 +72,16 @@ export function createIcon({ name, icon, rhUiIcon = null }: CreateIconProps): Re

id = `icon-title-${currentId++}`;

static defaultProps: SVGIconProps = {
noStandardSetStyling: false
};

constructor(props: SVGIconProps) {
super(props);
}

render() {
const { title, className: propsClassName, set, ...props } = this.props;
const { title, className: propsClassName, set, noStandardSetStyling, ...props } = this.props;

const hasTitle = Boolean(title);
const classNames = ['pf-v6-svg'];
Expand All @@ -99,7 +105,13 @@ export function createIcon({ name, icon, rhUiIcon = null }: CreateIconProps): Re
const viewBox = [_xOffset, _yOffset, width, height].join(' ');

if (svgClassName) {
classNames.push(svgClassName);
if (svgClassName !== 'pf-v6-icon-rh-standard') {
classNames.push(svgClassName);
} else {
if (!noStandardSetStyling) {
classNames.push(svgClassName);
}
}
}

const svgPaths =
Expand Down
2 changes: 1 addition & 1 deletion packages/react-styles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"clean": "rimraf dist css"
},
"devDependencies": {
"@patternfly/patternfly": "6.5.0-prerelease.62",
"@patternfly/patternfly": "6.5.0-prerelease.65",
"change-case": "^5.4.4",
"fs-extra": "^11.3.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-tokens/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"devDependencies": {
"@adobe/css-tools": "^4.4.4",
"@patternfly/patternfly": "6.5.0-prerelease.62",
"@patternfly/patternfly": "6.5.0-prerelease.65",
"fs-extra": "^11.3.3"
}
}
18 changes: 9 additions & 9 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5070,10 +5070,10 @@ __metadata:
languageName: node
linkType: hard

"@patternfly/patternfly@npm:6.5.0-prerelease.62":
version: 6.5.0-prerelease.62
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.62"
checksum: 10c0/e918cd5e92df7bd6d69e27394a0053a84bd82c5e7f5028bea101f4687019afb46887c6fd27cbbc8f0e759b66dd40a25315637fb509eef17066d319a6e82167d6
"@patternfly/patternfly@npm:6.5.0-prerelease.65":
version: 6.5.0-prerelease.65
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.65"
checksum: 10c0/5d6042bb3b3a562b3b1421395edbbd5899f84a3349d45be29f9d3d9a9e18968b8e86275f75a86b9a3720db905679b52a4227377b640c0096f498d584e5f4c2fb
languageName: node
linkType: hard

Expand Down Expand Up @@ -5171,7 +5171,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@patternfly/react-core@workspace:packages/react-core"
dependencies:
"@patternfly/patternfly": "npm:6.5.0-prerelease.62"
"@patternfly/patternfly": "npm:6.5.0-prerelease.65"
"@patternfly/react-icons": "workspace:^"
"@patternfly/react-styles": "workspace:^"
"@patternfly/react-tokens": "workspace:^"
Expand All @@ -5192,7 +5192,7 @@ __metadata:
resolution: "@patternfly/react-docs@workspace:packages/react-docs"
dependencies:
"@patternfly/documentation-framework": "npm:^6.36.8"
"@patternfly/patternfly": "npm:6.5.0-prerelease.62"
"@patternfly/patternfly": "npm:6.5.0-prerelease.65"
"@patternfly/patternfly-a11y": "npm:5.1.0"
"@patternfly/react-charts": "workspace:^"
"@patternfly/react-code-editor": "workspace:^"
Expand Down Expand Up @@ -5232,7 +5232,7 @@ __metadata:
"@fortawesome/free-brands-svg-icons": "npm:^5.15.4"
"@fortawesome/free-regular-svg-icons": "npm:^5.15.4"
"@fortawesome/free-solid-svg-icons": "npm:^5.15.4"
"@patternfly/patternfly": "npm:6.5.0-prerelease.62"
"@patternfly/patternfly": "npm:6.5.0-prerelease.65"
"@rhds/icons": "npm:^2.1.0"
fs-extra: "npm:^11.3.3"
tslib: "npm:^2.8.1"
Expand Down Expand Up @@ -5319,7 +5319,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@patternfly/react-styles@workspace:packages/react-styles"
dependencies:
"@patternfly/patternfly": "npm:6.5.0-prerelease.62"
"@patternfly/patternfly": "npm:6.5.0-prerelease.65"
change-case: "npm:^5.4.4"
fs-extra: "npm:^11.3.3"
languageName: unknown
Expand Down Expand Up @@ -5361,7 +5361,7 @@ __metadata:
resolution: "@patternfly/react-tokens@workspace:packages/react-tokens"
dependencies:
"@adobe/css-tools": "npm:^4.4.4"
"@patternfly/patternfly": "npm:6.5.0-prerelease.62"
"@patternfly/patternfly": "npm:6.5.0-prerelease.65"
fs-extra: "npm:^11.3.3"
languageName: unknown
linkType: soft
Expand Down
Loading