fix: clear in_save_handler state that blocks the subsequent close handler#2443
Merged
Conversation
Contributor
Author
|
@alexandre-daubois I'm not sure why the data race is surfacing in this PR specifically. I know you recently worked on the metrics so you're probably best prepared to figure it out. |
withinboredom
approved these changes
May 24, 2026
Member
|
It looks like the race is due to overlapping tests? Read in shutdown AND in startup, if I'm reading the traces right. |
AlliBalliBaba
approved these changes
May 26, 2026
Contributor
AlliBalliBaba
left a comment
AlliBalliBaba
left a comment
There was a problem hiding this comment.
Haven't looked into it yet, but might also be possible to fix this upstream in the long run
dunglas
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2368