Add Drupal to community build by andypost · Pull Request #10050 · php/php-src

andypost · 2022-12-05T07:51:42Z

running unit and kernel tests for groups: Annotation,Assertion,ClassFinder,Drupal,Extension,File,Plugin,Render,tar,zip
the Database group of unit and kernel tests using sqlite and mysql
taking around ~10 minutes

andypost · 2022-12-05T11:20:31Z

Looks to run kernel tests it needs SIMPLETEST_BASE_URL env variable and webserver (could use build-in one)

andypost · 2022-12-05T11:21:55Z

debugging on unit and build tests as they are fast, as all databases available using to test sqlite/mysql/pgsql connections

sqlite
Tests: 19452, Assertions: 34554, Failures: 4, Skipped: 2585, Incomplete: 3.
mysql
Tests: 19452, Assertions: 34545, Errors: 2, Failures: 4, Skipped: 2585, Incomplete: 3.
pgsql
Tests: 19452, Assertions: 34551, Failures: 4, Skipped: 2585, Incomplete: 3.

iluuu1994 · 2022-12-05T11:28:08Z

.github/workflows/push.yml

-            -d opcache.jit_buffer_size=16M
-      - name: Verify generated files are up to date
-        uses: ./.github/actions/verify-generated-files
+      - name: Test Drupal


You should move this to a new job for testing analogous to #9942. The binary needs to be built with the sanitize flags for this to be meaningful.

Yes,I will

ATM trying to connect to pgsql but it looks broken

I would just add another service like here: https://github.com/php/php-src/blob/master/.github/workflows/nightly.yml#L130-L137

Or just use the existing mysql db if you can.

Somehow pgsql connection has issues, I limited tests to sqlite and mysql now

iluuu1994

Thank you @andypost! A few comments. Can you also copy this to nightly to show that this will succeed? I will remove it when merging. 🙂

iluuu1994 · 2023-06-28T19:21:56Z

.github/workflows/nightly.yml

+        if: always()
+        run: |
+          php -i|grep memory_limit
+          echo memory_limit=256M > /etc/php.d/drupal.ini


This should be done in setup, as it will leak into the next step anyway. Increasing the memory limit generally should be ok.

Maybe this change could go separate file which will be removed at the end of script?

iluuu1994 · 2023-06-28T19:23:10Z

.github/workflows/nightly.yml

+          cd drupal
+          git rev-parse HEAD
+          php /usr/bin/composer install --no-progress --ignore-platform-reqs
+          export ASAN_OPTIONS=exitcode=139


Not your fault, but we could make ASAN_OPTIONS a global env var as it's always the same anyway.

Gonna file separate PR for that

iluuu1994 · 2023-06-28T19:25:41Z

.github/workflows/nightly.yml

+          mkdir db
+          rm -f core/tests/Drupal/FunctionalTests/ExistingDrupal8StyleDatabaseConnectionInSettingsPhpTest.php
+          export DRUPAL_TYPES=Annotation,Assertion,ClassFinder,Drupal,Extension,File,Plugin,Render,tar,zip
+          php -dzend.assertions=1 vendor/bin/phpunit -c core/phpunit.xml.dist --testsuite unit,kernel --group $DRUPAL_TYPES || exit 1


Is there a point to adding assertions? I'm not against it, but we if we do we should do so for all projects. Generally, we're not interested in correct behavior, just crashes/memory violations.

The point is that lots of tests require assertions to throw so php-unit can separate errors in data-providers

I used to pick the most important test groups and database connectors, my next goal is to add a benchmark like WP and SF has

andypost · 2026-04-09T14:58:56Z

Latest drupal core has reproducible failure

The regression remains consistently reproduced:

Opcache DISABLED: OK (386 tests, 915 assertions)
Opcache ENABLED: Fatal error: Invalid opcode 43/4/0 (ZEND_JMPZ) in Drupal/Core/Form/FormSubmitter.php on line 89.

run kernel and unit tests for pdo_sqlite and pdo_mysql

andypost force-pushed the 9992-drupal branch 2 times, most recently from 63d9a29 to 1ecbb16 Compare December 5, 2022 10:57

iluuu1994 reviewed Dec 5, 2022

View reviewed changes

andypost force-pushed the 9992-drupal branch 11 times, most recently from bcf45df to a60b38d Compare December 7, 2022 18:20

iluuu1994 mentioned this pull request Mar 29, 2023

Consider adding Drupal to community build #9992

Closed

andypost force-pushed the 9992-drupal branch 12 times, most recently from dc76130 to 1bc2eba Compare June 27, 2023 23:28

andypost marked this pull request as ready for review June 27, 2023 23:30

andypost requested a review from TimWolla as a code owner June 27, 2023 23:30

TimWolla removed their request for review June 28, 2023 07:58

iluuu1994 reviewed Jun 28, 2023

View reviewed changes

andypost force-pushed the 9992-drupal branch from 1bc2eba to 29c1465 Compare January 21, 2024 02:21

andypost force-pushed the 9992-drupal branch from 29c1465 to 24b8eff Compare April 9, 2026 14:09

github-actions bot added the Category: CI label Apr 9, 2026

Add Drupal to community build

dc904a6

run kernel and unit tests for pdo_sqlite and pdo_mysql

andypost force-pushed the 9992-drupal branch from 24b8eff to dc904a6 Compare April 9, 2026 16:32

Conversation

andypost commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andypost commented Dec 5, 2022

Uh oh!

andypost commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iluuu1994 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andypost Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andypost commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andypost commented Dec 5, 2022 •

edited

Loading

andypost commented Dec 5, 2022 •

edited

Loading

andypost Jun 29, 2023 •

edited

Loading