Respect sys_temp_dir from the parent process#5390
Open
theodorejb wants to merge 2 commits intophpstan:2.1.xfrom
Open
Respect sys_temp_dir from the parent process#5390theodorejb wants to merge 2 commits intophpstan:2.1.xfrom
theodorejb wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
Contributor
|
Can we e2e test the regression bug which gets fixed? |
Addresses phpstan/phpstan#13929 without the bug that caused phpstan#4699 to be reverted. Closes phpstan/phpstan#14093
The bug only manifests when the `sys_temp_dir` path starts with an alphanumeric character (like a drive letter on Windows, or a relative folder name on Linux).
theodorejb
force-pushed
the
respect-sys-temp-dir
branch
from
bc5fe7d to
4b3ea55
Compare
Author
Contributor
|
@dktapps could you double check this works for you? |
staabm
approved these changes
Apr 7, 2026
Contributor
staabm
left a comment
staabm
left a comment
There was a problem hiding this comment.
verified the test. it works for me.
thank you
VincentLanglet
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses phpstan/phpstan#13929 without the bug that caused #4699 to be reverted.
Closes phpstan/phpstan#14093