Closed
Conversation
…Devs are writing different pieces and those might be on different repos
Signed-off-by: entlein <einentlein@gmail.com>
without the perms will not be inherited Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
…d artefacts Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
…optional Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
…optional Signed-off-by: entlein <einentlein@gmail.com>
Co-authored-by: Dom Delnano <ddelnano@gmail.com> Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
Co-authored-by: Dom Delnano <ddelnano@gmail.com> Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
Co-authored-by: Dom Delnano <ddelnano@gmail.com> Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
linter Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
linter Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
testing my pr workflow against the new leading branch Signed-off-by: Duck <70207455+entlein@users.noreply.github.com>
Update .bazelrc
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
Signed-off-by: entlein <einentlein@gmail.com>
…don't have permission for (pixie-io#2333) GitOrigin-RevId: 5bf71d8
GitOrigin-RevId: e1a0043
GitOrigin-RevId: 57e15b3
Summary: Reduce boiler plate for Go container image C++ headers Previously, adding a new Go version required: 1. Creating new header files for each container type (grpc_server, grpc_client, tls_server, tls_client) 2. Adding BUILD.bazel entries for each new library 3. Updating test files with new #include statements These header files account for ~100-200 lines of boilerplate code per Go version (~50 lines for each grpc and tls client/server pair) and add overhead when upgrading our Go version. This PR reduces this boilerplate by generating these files with a new Bazel macro `go_container_libraries`. This macro generates: - Individual C++ headers for each version (e.g., `go_1_24_grpc_server_container.h`) - Aggregate headers that include all versions for a given container type (e.g., `go_grpc_server_containers.h`, `go_tls_client_containers.h`) Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Build should succeed Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: ce714e6
…don't have permission for (pixie-io#2333) GitOrigin-RevId: 5bf71d8
GitOrigin-RevId: e1a0043
GitOrigin-RevId: 57e15b3
Summary: Reduce boiler plate for Go container image C++ headers Previously, adding a new Go version required: 1. Creating new header files for each container type (grpc_server, grpc_client, tls_server, tls_client) 2. Adding BUILD.bazel entries for each new library 3. Updating test files with new #include statements These header files account for ~100-200 lines of boilerplate code per Go version (~50 lines for each grpc and tls client/server pair) and add overhead when upgrading our Go version. This PR reduces this boilerplate by generating these files with a new Bazel macro `go_container_libraries`. This macro generates: - Individual C++ headers for each version (e.g., `go_1_24_grpc_server_container.h`) - Aggregate headers that include all versions for a given container type (e.g., `go_grpc_server_containers.h`, `go_tls_client_containers.h`) Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Build should succeed Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: ce714e6
…don't have permission for (pixie-io#2333) GitOrigin-RevId: 5bf71d8
GitOrigin-RevId: e1a0043
GitOrigin-RevId: 57e15b3
Summary: Reduce boiler plate for Go container image C++ headers Previously, adding a new Go version required: 1. Creating new header files for each container type (grpc_server, grpc_client, tls_server, tls_client) 2. Adding BUILD.bazel entries for each new library 3. Updating test files with new #include statements These header files account for ~100-200 lines of boilerplate code per Go version (~50 lines for each grpc and tls client/server pair) and add overhead when upgrading our Go version. This PR reduces this boilerplate by generating these files with a new Bazel macro `go_container_libraries`. This macro generates: - Individual C++ headers for each version (e.g., `go_1_24_grpc_server_container.h`) - Aggregate headers that include all versions for a given container type (e.g., `go_grpc_server_containers.h`, `go_tls_client_containers.h`) Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Build should succeed Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: ce714e6
…don't have permission for (pixie-io#2333) GitOrigin-RevId: 5bf71d8
GitOrigin-RevId: e1a0043
GitOrigin-RevId: 57e15b3
Summary: Reduce boiler plate for Go container image C++ headers Previously, adding a new Go version required: 1. Creating new header files for each container type (grpc_server, grpc_client, tls_server, tls_client) 2. Adding BUILD.bazel entries for each new library 3. Updating test files with new #include statements These header files account for ~100-200 lines of boilerplate code per Go version (~50 lines for each grpc and tls client/server pair) and add overhead when upgrading our Go version. This PR reduces this boilerplate by generating these files with a new Bazel macro `go_container_libraries`. This macro generates: - Individual C++ headers for each version (e.g., `go_1_24_grpc_server_container.h`) - Aggregate headers that include all versions for a given container type (e.g., `go_grpc_server_containers.h`, `go_tls_client_containers.h`) Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Build should succeed Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: ce714e6
…don't have permission for (pixie-io#2333) GitOrigin-RevId: 5bf71d8
GitOrigin-RevId: e1a0043
GitOrigin-RevId: 57e15b3
Summary: Reduce boiler plate for Go container image C++ headers Previously, adding a new Go version required: 1. Creating new header files for each container type (grpc_server, grpc_client, tls_server, tls_client) 2. Adding BUILD.bazel entries for each new library 3. Updating test files with new #include statements These header files account for ~100-200 lines of boilerplate code per Go version (~50 lines for each grpc and tls client/server pair) and add overhead when upgrading our Go version. This PR reduces this boilerplate by generating these files with a new Bazel macro `go_container_libraries`. This macro generates: - Individual C++ headers for each version (e.g., `go_1_24_grpc_server_container.h`) - Aggregate headers that include all versions for a given container type (e.g., `go_grpc_server_containers.h`, `go_tls_client_containers.h`) Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Build should succeed Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: ce714e6
…don't have permission for (pixie-io#2333) GitOrigin-RevId: 5bf71d8
GitOrigin-RevId: e1a0043
GitOrigin-RevId: 57e15b3
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…export-vizier-release Fix adapative_export image name in vizier releases
Signed-off-by: entlein <einentlein@gmail.com>
entlein
requested a deployment
to
pr-actions-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing for the lab demo end of April