Fix error when creating databases on tvOS devices#470
Open
joseph-elmallah wants to merge 1 commit into
Open
Conversation
4 tasks
Member
I don't think that is the correct move. That will cause people to unknowingly store their database in a place that can be deleted at any moment. Please revert that change. People who develop for tvOS will just have to know that they need to provide a URL to |
…port On tvOS, `.applicationSupportDirectory` is unavailable, so switch to `.cachesDirectory` for the default database path. Also remove redundant `createDirectory` calls that are now handled by `FileManager.default.url(create:true)`.
joseph-elmallah
force-pushed
the
support-tvos
branch
from
bb5f7df to
7977f7b
Compare
joseph-elmallah
changed the title
Author
|
@mbrandonw I reverted that change and updated the PR description + title to reflect the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant
createDirectorycalls that are now handled byFileManager.default.url(create:true).