fix: restored p5.js keyword highlighting for CM6 #3868#4141
Open
parthjadhao01 wants to merge 1 commit into
Open
fix: restored p5.js keyword highlighting for CM6 #3868#4141parthjadhao01 wants to merge 1 commit into
parthjadhao01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3868
This PR restores p5.js-specific syntax highlighting in the CodeMirror v6 branch. In the CM5 editor, p5 functions (like
setup,draw,background) appeared bold blue and p5 constants/variables (likePI,mouseX,WEBGL) appeared pink. This styling was missing in the CM6 branch.Demo:
after fix :
befor fix :
Changes:
p5Highlight.js— a CM6ViewPluginthat walks the Lezer syntax tree over visible ranges, checks eachVariableNameandVariableDefinitionnode against the p5 keyword lists fromp5-keywords.js, and appliescm-p5-functionorcm-p5-variabledecorations_editor.scss— added styles for.cm-p5-function(bold blue) and.cm-p5-variable(pink) using existing theme variables so all three themes (light, dark, high-contrast) are supportedstateUtils.js— registeredp5Highlightin the extensions arrayI have verified that this pull request:
npm run lint)npm run test)npm run typecheck)develop-codemirror-v6branch.Fixes #3868