Implement --fail-all-on-failed-ordering#246
Conversation
mrbean-bremen
left a comment
mrbean-bremen
left a comment
There was a problem hiding this comment.
Thanks again! Only one small remark.
| import sys | ||
| from typing import Optional, Generic, TypeVar | ||
|
|
||
| from _pytest.config.exceptions import UsageError |
There was a problem hiding this comment.
This can be directly imported from pytest (same for Function below).
| from warnings import warn | ||
|
|
||
| from _pytest.config import Config | ||
| from _pytest.config.exceptions import UsageError |
There was a problem hiding this comment.
see above, may also fix the following imports (avoiding private imports)
There was a problem hiding this comment.
...rebased and pushed again.
There was a problem hiding this comment.
Ugh, looks like one can only import Config from pytest on Python 3.14 - by the the look of the CI.
Experimenting...
There was a problem hiding this comment.
Hm, this seems to be supported only from pytest 7 onward. Maybe it's time to kill support for pytest 6... It does not support Python 3.14 anyway, that's why this version is not tested there. But that is for a later version, I think, so we should keep the private imports for now, sorry for the wrong assumption.
victor-nexthop
force-pushed
the
feature.fail-on-ordering
branch
5 times, most recently
from
28bb611 to
50ba45d
Compare
victor-nexthop
force-pushed
the
feature.fail-on-ordering
branch
from
50ba45d to
ccd568a
Compare
|
Thanks for merging! Looking forward to next release :) |
|
The release is out. |
2 participants
One more PR!
I want my tests to not even attempt running if there is an ordering problem, and to test ordering with
--collect-only.(vibed).