Fix Argument.__repr__ crash when _action is not initialized#14429
Open
EternalRights wants to merge 2 commits intopytest-dev:mainfrom
Open
Fix Argument.__repr__ crash when _action is not initialized#14429EternalRights wants to merge 2 commits intopytest-dev:mainfrom
EternalRights wants to merge 2 commits intopytest-dev:mainfrom
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
EternalRights
force-pushed
the
fix-argparse-attrerror
branch
from
4f863ed to
4cd4ca7
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while looking at #13817. When
Argument.__init__doesn't complete (e.g. ifargparse.Actionraises during construction), callingrepr()on the partially-initializedArgumenttriggers a secondaryAttributeErrorbecauseself._actiondoesn't exist yet. This masks the original error message.The fix uses
getattr(self, "_action", None)in__repr__and returns"Argument(<uninitialized>)"when_actionis missing, as RonnyPfannschmidt suggested. This way the original exception message gets through instead of being buried under a secondary crash.