gh-118318: Remove outdated c14n references from ElementTree#118319
Open
danifus wants to merge 3 commits into
Open
gh-118318: Remove outdated c14n references from ElementTree#118319danifus wants to merge 3 commits into
danifus wants to merge 3 commits into
Conversation
Some references to a removed `c14n` serialization method remained in ElementTree.py. Attempting to use `method='c14n'` in the `write()` method would result in `ValueError: unknown method 'c14n'`. Removes the `write_c14n()` method that uses `method='c14n'` and also raises the same error.
|
This PR is stale because it has been open for 30 days with no activity. |
serhiy-storchaka
requested changes
May 25, 2026
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please add a NEWS entry and a What's New entry for this change.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some references to a removed
c14nserialization method remained in ElementTree.py. Attempting to usemethod='c14n'in thewrite()method would result inValueError: unknown method 'c14n'.Removes the
write_c14n()method that usesmethod='c14n'and also raises the same error.method='c14n'references from ElementTree #118318