gh-149010: Improve reliability of inspect CLI#149357
Merged
ncoghlan merged 4 commits intopython:mainfrom May 4, 2026
Merged
Conversation
* Handle non-source modules more gracefully (and consistently) * Improve handling of frozen modules (which may or may not have source) * Avoid reporting misleading info when looking up objects via aliases * Refactor CLI implementation to improve testability * Add several more test cases Closes python#149010
Contributor
Author
|
Some before-and-after examples. Before: After: Before: After: Before: After: |
Documentation build overview
|
ncoghlan
commented
May 4, 2026
hugovk
approved these changes
May 4, 2026
|
|
||
| def _clean_object_ids(text): | ||
| # Helper to handle "<obj at 0x...>" details in CLI output checks | ||
| import re |
Member
There was a problem hiding this comment.
It's okay to put this at the top for tests. Can even lazy import re if you want.
There's also one in test_re_module_has_signatures we could move.
Contributor
Author
There was a problem hiding this comment.
Given how long the CI takes to run, I'm going to put that on the "try to remember to clean that up next time I touch this module" list :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149010