Skip to content

gh-150001: fix escalation to SystemError during parsing#150067

Open
sandugood wants to merge 6 commits into
python:mainfrom
sandugood:gh-150001
Open

gh-150001: fix escalation to SystemError during parsing#150067
sandugood wants to merge 6 commits into
python:mainfrom
sandugood:gh-150001

Conversation

@sandugood
Copy link
Copy Markdown

@sandugood sandugood commented May 19, 2026 •
edited
Loading

Added a regression test as well (with the string generated by fuzzer in the issue).

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 19, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented May 19, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2026
Open
JelleZijlstra
JelleZijlstra reviewed May 19, 2026
View reviewed changes
Comment thread Lib/test/test_compile.py Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 19, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@sandugood
Copy link
Copy Markdown
Author

sandugood commented May 23, 2026

I think that this fix doesn't require a NEWS entry. But I am opened to suggestions

@pablogsal pablogsal added awaiting review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed awaiting merge labels May 23, 2026
@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented May 23, 2026

We need a news entry can you add one please?

@sandugood
Copy link
Copy Markdown
Author

sandugood commented May 23, 2026

Yes, sure. Thanks for the review

@sandugood
Copy link
Copy Markdown
Author

sandugood commented May 23, 2026

Seems that the CI error is not related to the PR itself.

@JelleZijlstra
Copy link
Copy Markdown
Member

JelleZijlstra commented May 23, 2026

I retried it

@sandugood
Copy link
Copy Markdown
Author

sandugood commented May 23, 2026

I retried it

Looks like it is a github issue? The run itself doesnt get to the building stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

awaiting review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandugood @pablogsal @JelleZijlstra