Skip to content

Allow reverse operator methods on protocols #21538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Will-thom wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

Allow reverse operator methods on protocols #21538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1962,6 +1962,9 @@ def check_reverse_op_method(

assert defn.info

if defn.info.is_protocol:
return

# First check for a valid signature
method_type = CallableType(
[AnyType(TypeOfAny.special_form), AnyType(TypeOfAny.special_form)],
Expand Down
11 changes: 11 additions & 0 deletions test-data/unit/check-protocols.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1539,6 +1539,17 @@ f(C()) # E: No overload variant of "f" matches argument type "C" \
[builtins fixtures/isinstance.pyi]
[typing fixtures/typing-full.pyi]

[case testProtocolReversePowWithModulo]
from typing import overload, Protocol

class PowableProto(Protocol):
@overload
def __rpow__(self, other: "PowableProto") -> "PowableProto": ...
@overload
def __rpow__(
self, other: "PowableProto", modulo: "PowableProto"
) -> "PowableProto": ...

-- Unions of protocol types
-- ------------------------

Expand Down
Loading