runtime/executor: null-check backend_delegate_data#19904
Open
vacu9708 wants to merge 1 commit into
Open
Conversation
`backend_delegate_data` is an optional FlatBuffer vector — legitimately absent when no inline delegate blobs exist. The accessor dereferenced it without a null check, causing a SIGSEGV on any such PTE. Neither the FlatBuffer verifier nor validate_program catches this, so the crash was reachable under both Minimal and InternalConsistency verification. - Add `data_list != nullptr` guard; return `InvalidProgram` if absent. - Add `data != nullptr` guard on the per-entry data field. Continues the loader-hardening work in pytorch#16704, pytorch#18724, and pytorch#19267. Signed-off-by: Youngsik Yang <vacu9708@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19904
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
vacu9708
changed the title
: null-check backend_delegate_data`runtime/executor: null-check backend_delegate_data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the loader-hardening work in #16704, #18724, and #19267.
Bug
backend_delegate_datais an optional FlatBuffer vector (schema/program.fbs:506, no(required)attribute).flowchart LR A["Method::load\nmethod.cpp:839"] -->|"for each BackendDelegate"| B["GetProcessedData\nmethod.cpp:193"] B -->|"location == INLINE"| C["get_backend_delegate_data\nprogram.cpp:534"] C -->|"backend_delegate_data() == null"| D["SIGSEGV"]Fix
Add a null guard before the existing size check:
backend_delegate_data()is nullInvalidProgramentry->data()is nullInvalidProgramInvalidProgramis used (rather thanNotFound) because an absentbackend_delegate_datawhile a delegate references inline data indicates a corrupt file, not a normal lookup miss. Happy to change if you preferNotFoundfor symmetry with the index check.The
GetProcessedDatafunction has two structurally parallel unguarded derefs (delegate.processed(),delegate.id()->c_str()); left for a follow-up to keep this PR focused.Tests