rpieepromab: Check bootloader minimum version#195
Merged
Conversation
timg236
reviewed
Jun 1, 2026
| return -1; | ||
| } | ||
|
|
||
| for (size_t i = 0; i < n; i++) { |
Contributor
There was a problem hiding this comment.
Could you use ntohl instead ?
mathewb64
force-pushed
the
rpieepromab-mfg-ver-check
branch
from
a34c34b to
5f85a46
Compare
timg236
reviewed
Jun 1, 2026
| return -1; | ||
| } | ||
|
|
||
| for (size_t i = 0; i + marker_len <= data_len; i++) { |
Contributor
There was a problem hiding this comment.
Sorry, I've just realised that you could use memmem here instead for a simpler search
mathewb64
force-pushed
the
rpieepromab-mfg-ver-check
branch
from
5f85a46 to
4d283c5
Compare
timg236
approved these changes
Jun 1, 2026
pelwell
reviewed
Jun 1, 2026
| } | ||
|
|
||
| memcpy(&tmp, buf, sizeof(tmp)); | ||
| *min_boot_ver = ntohl(tmp); |
Collaborator
There was a problem hiding this comment.
It's not a strong preference - I leave it up to you to decide - but have you considered:
*min_boot_ver = (buf[0] << 24) | (buf[1] << 16) | (buf[2] << 8) | buf[3];
and dropping tmp, the memcpy and the include (and GNU_SOURCE?)?
Contributor
Author
There was a problem hiding this comment.
yeah that looks better
Abort the update if the version of the provided update is less than the bootloader minimum version of the board.
mathewb64
force-pushed
the
rpieepromab-mfg-ver-check
branch
from
4d283c5 to
122bc4f
Compare
pelwell
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abort the update if the version of the provided update is less than the bootloader minimum version of the board.