Fix release workflow docs and Ruby 3.2 bundle install#1393
Conversation
PR Review: Fix release workflow docs and Ruby 3.2 bundle installOverall this is a clean, well-scoped PR with a clear motivation. The changes are low-risk and address a real maintainer pain point. A few observations below. Documentation fixes (
|
| Area | Assessment |
|---|---|
| Documentation fixes | Correct and helpful |
| nokogiri pin | Well-reasoned, appropriate constraint |
| Lockfile changes | Correct; minor question about byebug bump scope |
| Test coverage | N/A — infrastructure/docs only |
| Security | No new concerns introduced; pre-existing http:// source URL worth a follow-up |
The core goal — unblocking maintainers on modern macOS + Ruby 3.2 while keeping Ruby 2.7 CI green — is well-served by these changes. Nice work keeping the scope tight.
Summary
This unblocks maintainers running the release workflow on modern macOS + Ruby 3.2 while keeping the existing Ruby 2.7 CI matrix compatible.
Changes
nokogiriinGemfileto~> 1.15.7Gemfile.lock:byebug11.0.1 -> 11.1.3nokogiri1.14.3 -> 1.15.7 (including arm64-darwin platform entry)rakelib/create_release.rakedescription:rake release[...]->rake create_release[...]CONTRIBUTING.mdVerification
mise exec ruby@3.2.9 -- bundle _2.4.9_ installmise exec ruby@3.2.9 -- bundle exec rake -D create_release