Skip to content

ENG-9738: Fix Mobile docs sidebar scroll#6635

Merged
masenf merged 1 commit into
mainfrom
carlos/fix-mobile-drawer-scroll
Jun 9, 2026
Merged

ENG-9738: Fix Mobile docs sidebar scroll#6635
masenf merged 1 commit into
mainfrom
carlos/fix-mobile-drawer-scroll

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested review from a team and Alek99 as code owners June 9, 2026 09:18
@linear-code

linear-code Bot commented Jun 9, 2026

Copy link
Copy Markdown

ENG-9738

@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jun 9, 2026
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the mobile docs sidebar scroll by correcting the drawer's height calculation and flex layout. It also includes an unrelated CSS rule that hides the PostHog chat widget button.

  • sidebar.py: Replaces h-full with h-[calc(100dvh-4rem)] (using the dynamic viewport unit appropriate for mobile browsers) and adds flex-1 min-h-0 to the inner container — the standard pattern for enabling overflow/scroll in a flex subtree.
  • tailwind-theme.css: Adds display: none !important rules targeting the PostHog conversations widget button and its adjacent sibling div; this change is unrelated to the stated goal and lacks an explanatory comment.

Confidence Score: 4/5

The sidebar layout fix is straightforward and correct; the only thing worth a second look is the PostHog widget CSS bundled into this PR without explanation.

The core sidebar change is a well-understood CSS flex pattern and looks correct. The CSS file also hides a third-party chat widget with no comment or justification, making it unclear whether this is intentional or a side effect. The adjacent-sibling selector is brittle but not harmful right now.

docs/app/assets/tailwind-theme.css — contains the unexplained PostHog widget suppression rules.

Important Files Changed

Filename Overview
docs/app/reflex_docs/components/docpage/navbar/buttons/sidebar.py Fixes mobile sidebar scroll by replacing h-full with h-[calc(100dvh-4rem)] on the drawer content and adding flex-1 min-h-0 to the inner box — standard flex-overflow fix, changes look correct.
docs/app/assets/tailwind-theme.css Hides a PostHog chat widget button and its adjacent sibling div using display: none !important; unrelated to the sidebar scroll fix and lacks a trailing newline.

Reviews (1): Last reviewed commit: "ENG-9738: Fix Mobile docs sidebar scroll" | Re-trigger Greptile

Comment thread docs/app/assets/tailwind-theme.css
Comment thread docs/app/assets/tailwind-theme.css
@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.68%

❌ 1 regressed benchmark
✅ 25 untouched benchmarks
⏩ 8 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_get_all_imports[_complicated_page] 2.8 ms 3 ms -4.68%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing carlos/fix-mobile-drawer-scroll (5cc3e44) with main (6f5c80b)2

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (e4a9365) during the generation of this report, so 6f5c80b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@masenf masenf merged commit dcd87a1 into main Jun 9, 2026
106 of 107 checks passed
@masenf masenf deleted the carlos/fix-mobile-drawer-scroll branch June 9, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants