refactor: rename overloaded constructors to from* names [codex]#255
refactor: rename overloaded constructors to from* names [codex]#255jderochervlk wants to merge 23 commits intomainfrom
Conversation
Port the surviving API cleanup from the final pre-alpha branch onto the monorepo split introduced in #249. This adds the missing concrete modules, translates the fetch/runtime/canvas/websocket/media surface cleanup into the package layout, and keeps the branch green with updated tests.
Drop scroll2/scrollTo2/scrollBy2 and keep the descriptive *XY overload names requested in review. Co-authored-by: Codex <codex@openai.com>
…with-commits-and-responses Address review feedback: rename constructors, unbox FormDataEntryValue, reuse MessageEvent types, simplify tests
…-webapi into codex/issue-236-constructor-from-names-carryover
Update DOMMatrix, DOMMatrixReadOnly, Path2D, and ReadableStream single-source constructor overloads to take direct unlabeled arguments. Refresh compile-coverage tests and contributor documentation to match the constructor naming convention.
Remove source-shape callouts from the constructor docs added in this PR. Rewrite constructor summaries to focus on the ReScript API surface and update the contributor documentation guidance to match.
jderochervlk
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c7ece03a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tsnobip
left a comment
tsnobip
left a comment
There was a problem hiding this comment.
except from the sharedArrayBuffer, the rest looks good to me!
| @@ -1,89 +1,177 @@ | |||
| type sharedArrayBuffer = unknown | |||
There was a problem hiding this comment.
I think this should use ArrayBufferTypedArrayOrDataView.t
https://github.com/rescript-lang/experimental-rescript-webapi/blob/main/packages/Base/src/ArrayBufferTypedArrayOrDataView.res
or even better, write a different binding for each possible case (ArrayBuffer, TypedArray, DataView), this type should be kept only for cases when you can't write multiple bindings, like in record types for example, otherwise in VideoFrame or SubtleCrypto bindings, it should likely use different bindings.
2 participants
Summary
from*source-type namesmake()sharedArrayBufferalias inVideoFrameValidation
npm run buildASTRO_TELEMETRY_DISABLED=1 npm run build:docsNotes
npm run format:checkstill reports pre-existing failures oncarryover/post-249-pre-alphafix: rename overloaded constructors to from names*
style: format Path2D on carryover branch
refactor: localize VideoFrame shared array buffer alias