fix: add engines field to specify Node version compatibility#112
Merged
chenjiahan merged 3 commits intomainfrom Mar 28, 2026
Merged
fix: add engines field to specify Node version compatibility#112chenjiahan merged 3 commits intomainfrom
chenjiahan merged 3 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the build, development, and test scripts in package.json and introduces a Node.js version requirement in the engines field. A critical issue was identified regarding the specified Node.js versions, which appear to be future releases that would prevent installation on current environments; a suggestion was provided to use existing LTS versions.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates create-rstack’s published metadata to prevent installs on unsupported Node.js versions (per Issue #110), aligning Node compatibility with transitive requirements introduced by rslog@2.
Changes:
- Add an explicit
engines.noderange (^20.19.0 || >=22.12.0) to match dependencies’ Node requirements. - Update
scriptscommands forrslib/rstestinvocations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#110