Skip to content

chore: switch to Rslint for linting #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Mar 28, 2026
Merged

chore: switch to Rslint for linting #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pnpm-lock.yaml
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.prettierignore currently ignores only pnpm-lock.yaml. Since dist/ and test output directories are generated (and already ignored by git / rslint), consider adding them here too so prettier --write . won’t reformat build artifacts by accident.

Suggested change
pnpm-lock.yaml
pnpm-lock.yaml
# Build artifacts
dist/
# Test output directories
coverage/
test-results/

Copilot uses AI. Check for mistakes.
3 changes: 3 additions & 0 deletions .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"singleQuote": true
}
2 changes: 1 addition & 1 deletion .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"recommendations": ["biomejs.biome"]
"recommendations": ["rstack.rslint", "esbenp.prettier-vscode"]
}
15 changes: 0 additions & 15 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
{
"search.useIgnoreFiles": true,
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode/settings.json is invalid JSON after removing the formatter settings because line 2 now ends with a trailing comma. VS Code won’t be able to parse this file; remove the trailing comma (or add another property).

Suggested change
"search.useIgnoreFiles": true,
"search.useIgnoreFiles": true

Copilot uses AI. Check for mistakes.
"[json]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[typescript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[javascript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[javascriptreact]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[css]": {
"editor.defaultFormatter": "biomejs.biome"
}
}
35 changes: 0 additions & 35 deletions biome.json
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"scripts": {
"build": "rslib",
"dev": "rslib --watch",
"lint": "biome check .",
"lint:write": "biome check . --write",
"lint": "rslint",
"prepare": "simple-git-hooks && rslib",
"test": "rstest",
"bump": "npx bumpp"
Expand All @@ -36,14 +35,14 @@
},
"nano-staged": {
"*.{js,jsx,ts,tsx,mjs,cjs}": [
"biome check --write --no-errors-on-unmatched"
"rslint && prettier --write"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current nano-staged command will cause rslint to run on the entire project for every commit, instead of only on the staged files. This is because nano-staged appends filenames to the end of the whole command string, so rslint doesn't receive them.

To fix this and improve efficiency, list rslint and prettier as separate commands in the array. This ensures each tool runs only on the relevant staged files.

      "rslint",
      "prettier --write"

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Split nano-staged tasks instead of chaining with &&

Use separate nano-staged entries here rather than a single "rslint && prettier --write" string. nano-staged tokenizes each command and executes it directly (no shell), so this value is treated as running rslint with literal arguments like && and prettier, which causes the pre-commit hook (npx nano-staged) to fail for staged JS/TS files instead of running both tools.

Useful? React with 👍 / 👎.

]
},
"devDependencies": {
"@biomejs/biome": "2.4.9",
"@clack/prompts": "^1.1.0",
"@microsoft/api-extractor": "^7.57.7",
"@rslib/core": "0.20.1",
"@rslint/core": "^0.3.3",
"@rstest/core": "0.9.5",
"@types/cross-spawn": "^6.0.6",
"@types/fs-extra": "^11.0.4",
Expand All @@ -54,6 +53,7 @@
"deepmerge": "^4.3.1",
"fs-extra": "^11.3.4",
"minimist": "^1.2.8",
"prettier": "^3.8.1",
"rimraf": "^6.1.3",
"rslog": "^2.1.0",
"simple-git-hooks": "^2.13.1",
Expand Down
174 changes: 79 additions & 95 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions rslint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { defineConfig, ts } from '@rslint/core';

export default defineConfig([
{ ignores: ['**/dist/**'] },
ts.configs.recommended,
]);
Loading