chore: replace biome with prettier and rslint#424
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the repo’s root formatting/linting and git-hook setup away from Biome and onto Prettier, Rslint, and simple-git-hooks.
Changes:
- Add Prettier configuration (
.prettierrc,.prettierignore) and a newrslint.config.ts. - Update root tooling scripts and hooks in
package.json(including replacing Husky with simple-git-hooks). - Remove Biome config and clean up some Biome-specific ignore directives and editor recommendations.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
rstest/rspack-adapter/tests/rstest.setup.ts |
Removes a Biome-specific ignore directive. |
rspack/worker/chat-worker.js |
Removes a Biome-specific ignore directive around switch fallthrough. |
rslint.config.ts |
Introduces root Rslint configuration and ignore patterns. |
rsbuild/vue-vant/components.d.ts |
Removes a Biome-specific ignore directive in a generated declaration file. |
rsbuild/vue-vant/auto-imports.d.ts |
Removes a Biome-specific ignore directive in a generated declaration file. |
package.json |
Replaces Biome/Husky setup with Prettier, Rslint, lint-staged updates, and simple-git-hooks wiring. |
biome.json |
Removes the root Biome configuration file. |
AGENTS.md |
Updates contributor/agent guidance to reflect Prettier + Rslint and adjusts formatting. |
.vscode/settings.json |
Switches default formatter from Biome to Prettier extension. |
.vscode/extensions.json |
Updates extension recommendations from Biome to Prettier. |
.prettierrc |
Adds root Prettier settings matching prior formatting intent. |
.prettierignore |
Adds ignore rules for common generated/build output. |
.husky/pre-commit |
Removes Husky pre-commit hook script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "lint": "rslint && prettier -c .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", | ||
| "lint:write": "prettier -w .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", |
There was a problem hiding this comment.
The lint script only runs Prettier in check mode against a small, explicit list of root files, so formatting regressions in the actual example sources (e.g. rspack/, rsbuild/, etc.) won’t be caught by pnpm run lint. Consider changing this to a repo-wide Prettier check (e.g. run Prettier against the workspace globs or . with .prettierignore) so the replacement of Biome’s formatter is enforced consistently.
| "lint": "rslint && prettier -c .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", | |
| "lint:write": "prettier -w .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", | |
| "lint": "rslint && prettier -c .", | |
| "lint:write": "prettier -w .", |
| ## Coding Conventions | ||
|
|
||
| - Formatting and linting: `Biome` is used (see `biome.json`). | ||
| - Formatting and linting: `Prettier` and `Rslint` are used (see `.prettierrc` and `rslint.config.ts`). | ||
| - Default JS/TS quote style is single quotes. | ||
| - Line width is 100. |
There was a problem hiding this comment.
The PR description says the remaining Biome-specific directives were updated, but there are still // biome-ignore directives present in other tracked files (e.g. rsbuild/vue-auto-import/auto-imports.d.ts, rsbuild/vue-element-plus/auto-imports.d.ts, rsbuild/vue-element-plus/components.d.ts). Either update/remove those directives as well or clarify in the description that only a subset was migrated in this PR.
Summary
Related Links