Skip to content

ssl: refactor SSLSocket#{peer_,}finished_message #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhenium merged 1 commit into from
Apr 29, 2026
+13 −14
Merged

ssl: refactor SSLSocket#{peer_,}finished_message #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions ext/openssl/ossl_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,16 +2482,15 @@ ossl_ssl_get_verify_result(VALUE self)

/*
* call-seq:
* ssl.finished_message => "finished message"
*
* Returns the last *Finished* message sent
* ssl.finished_message -> string or nil
*
* Returns the contents of the last +Finished+ message sent to the peer.
*/
static VALUE
ossl_ssl_get_finished(VALUE self)
{
SSL *ssl;
char sizer[1], *buf;
char sizer[1];
size_t len;

GetSSL(self, ssl);
Expand All @@ -2500,23 +2499,23 @@ ossl_ssl_get_finished(VALUE self)
if (len == 0)
return Qnil;

buf = ALLOCA_N(char, len);
SSL_get_finished(ssl, buf, len);
return rb_str_new(buf, len);
VALUE str = rb_str_new(NULL, len);
SSL_get_finished(ssl, RSTRING_PTR(str), len);
return str;
}

/*
* call-seq:
* ssl.peer_finished_message => "peer finished message"
*
* Returns the last *Finished* message received
* ssl.peer_finished_message -> string or nil
*
* Returns the contents of the last +Finished+ message expected to be sent
* by the peer.
*/
static VALUE
ossl_ssl_get_peer_finished(VALUE self)
{
SSL *ssl;
char sizer[1], *buf;
char sizer[1];
size_t len;

GetSSL(self, ssl);
Expand All @@ -2525,9 +2524,9 @@ ossl_ssl_get_peer_finished(VALUE self)
if (len == 0)
return Qnil;

buf = ALLOCA_N(char, len);
SSL_get_peer_finished(ssl, buf, len);
return rb_str_new(buf, len);
VALUE str = rb_str_new(NULL, len);
SSL_get_peer_finished(ssl, RSTRING_PTR(str), len);
return str;
}

/*
Expand Down