Rename some keyword locations for consistency#4060
Rename some keyword locations for consistency#4060
Conversation
Prism is generally good about their naming but these had some inconsistencies compared to others: * `InNode` was missing the `keyword` in the name * `MatchPredicateNode` `in` was named `operator` instead * `UnlessNode`/`UntilNode`/`WhenNode`/`WhileNode` has more than one keyword, with one generic `keyword_loc` * `UntilNode`/`WhileNode` named their `end` keyword `closing_loc` Left the old names around for compatibility
|
I'm generally okay with doing this, but I just want to check — can you enumerate our rules for naming? Maybe we should explicitly write them down? Is it |
|
Yeah, you got that right basically. Some like
I don't really know what where to put docs about general rules, is there a place that would fit? I can write something if you want (although I don't think it would be relevant very often, should just look at rdoc) |
Prism is generally good about their naming but these had some inconsistencies compared to others:
InNodewas missing thekeywordin the nameMatchPredicateNodeinwas namedoperatorinsteadUnlessNode/UntilNode/WhenNode/WhileNodehas more than one keyword, with one generickeyword_locUntilNode/WhileNodenamed theirendkeywordclosing_locLeft the old names around for compatibility