Conversation
They need wildcards, otherwise they don't match. Previously it always ran on PRs but in github.com/ruby/ruby-prism/commit/c4d202dc4866d6f03cc6cbda083a8950c6e6e42e I also applied it it PRs. That means that previously it didn't run on main. This fixes this
…group" This reverts commit 39f0519.
Collaborator
Author
|
#4093 bumped JRuby but it fails CI (didn't actually run) so I reverted it (cc @andreaTP |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They need wildcards, otherwise they don't match.
Previously it always ran on PRs but in https://github.com/ruby/ruby-prism/commit/c4d202dc4866d6f03cc6cbda083a8950c6e6e42e I also applied it to PRs.
That means that previously it didn't run on main only.
This fixes this.