Fix System Banner Tests to Use Correct Directive to Format Date Time String

[yagosansz]

What github issue is this PR for, if any?

Resolves #6806

What changed, and why?

Updated date time string directives so that date can be formatted and entered properly for expires at during banner creation or update.

How is this tested? (please write rspec and jest tests!) 💖💪

Updated flaky test.

Screenshots please :)

Not applicable 👍

[compwron]

tests are failing in Github Actions, please take a look

[yagosansz]

tests are failing in Github Actions, please take a look

Hi @compwron I think this breaks because when the tests run they run on Chrome. I also tested manually on Safari and they would break too.

I have to test running on Chromium to see if it'd break or not. Have you faced that issue before?

[compwron]

tests are failing in Github Actions, please take a look

Hi @compwron I think this breaks because when the tests run they run on Chrome. I also tested manually on Safari and they would break too.

I have to test running on Chromium to see if it'd break or not. Have you faced that issue before?

@yagosansz the tests run in CI via chromium on docker, and also in rspec directly on GHA.

example spec failure:

  1) Banners lets you create banner with expiration time and edit it
     Failure/Error: expect(page).to have_text("Expiring Announcement Yes in 7 days")
       expected to find text "Expiring Announcement Yes in 7 days" in "Supervisors\nVolunteers\nOther Duties\nCases\nAdmins\nLearning Hours\nBanners\nGroup Actions\nEdit Organization\nUser 1857\nNew Banner\nName\nActive?\nExpires at (optional)\nContent\nBold\nItalic\nStrikethrough\nLink\nHeading\nQuote\nCode\nBullets\nNumbers\nDecrease Level\nIncrease Level\nAttach Files\nUndo\nRedo\nPlease fill out this survey.\nSubmit\n© CASA / Volunteer Tracking\nBuilt with by Ruby For Good\nReport a site issue\nSMS Terms & Conditions"

[compwron]

Any news here on spec fixes?

[yagosansz]

Any news here on spec fixes?

Hi @compwron, my apologies for the delay on this. I had to travel for work and only now could check the PR.

I was unable to figure out why it was originally failing on my side. I did see your PR here #6832.

Could you please help me understand what is the difference between your solution now and what we had previously that was causing the specs to fail? 🙏