fix(resource-menu): consistent height between 1 result and no results#4007
fix(resource-menu): consistent height between 1 result and no results#4007waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 26ebd55. Configure here. |
Greptile SummaryThis PR fixes a subtle visual height inconsistency in the resource menu's search state: when search results transition from one item to zero items, the container height was shifting by 2 px because the "No results" fallback
Confidence Score: 5/5Safe to merge — minimal one-class CSS fix with no logic changes. Both changed lines are isolated Tailwind class corrections that align the 'No results' div height with DropdownMenuItem. No functional behavior, data handling, or API changes. No issues were introduced by this PR. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User types in search input] --> B{search query empty?}
B -- Yes --> C[Show category sub-menus]
B -- No --> D{filtered results count}
D -- greater than 0 --> E[Render DropdownMenuItems\npadding: px-2 py-1.5]
D -- equals 0 --> F[Render 'No results' div\npadding: px-2 py-1.5\n✅ now matches item height]
F -. before fix .-> G[py-5px caused\n2px height jump]
Reviews (1): Last reviewed commit: "fix(resource-menu): consistent height be..." | Re-trigger Greptile |
Summary
py-1.5padding on the "No results" div to align withDropdownMenuItempaddingType of Change
Testing
Tested manually
Checklist