Conversation
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📣 A few callouts for reviewers!
| while (nextCursor == null || !nextCursor.isEmpty()) { | ||
| // Using async client to avoid an exception due to rate limited errors | ||
| UsersListResponse response = asyncClient.usersList(r -> r | ||
| .includeLocale(true) | ||
| .limit(3000) | ||
| ).get(); | ||
| UsersListRequest.UsersListRequestBuilder req = UsersListRequest.builder() | ||
| .token(botToken).includeLocale(true).limit(200).cursor(nextCursor); | ||
| UsersListResponse response = client.usersList(req.build()); | ||
| nextCursor = response.getResponseMetadata().getNextCursor(); | ||
| userIds.addAll(response.getMembers().stream().map(User::getId).collect(toList())); | ||
| } |
There was a problem hiding this comment.
🔬 note: Here we prefer to use nextCursor for extended results
| .build()); | ||
| assertThat(response.isOk(), is(false)); | ||
| assertThat(response.getError(), is("missing_required_argument")); | ||
| assertThat(response.getError(), is("invalid_arguments")); |
There was a problem hiding this comment.
🧪 note: This expected error might've changed on the server side since a more recent run?
🔍 edit: Or perhaps #1574 changed this!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
============================================
- Coverage 73.23% 73.22% -0.02%
- Complexity 4515 4516 +1
============================================
Files 477 477
Lines 14285 14285
Branches 1488 1488
============================================
- Hits 10462 10460 -2
Misses 2934 2934
- Partials 889 891 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🎁 Will merge now to match the latest upstream! |
1 participant
This PR updates the web API client and model based on the production E2E test results - follows #1550.
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.