Skip to content

feat: Warn when unsupported OIDC client auth method is configured#877

Merged
dervoeti merged 5 commits intomainfrom
feat/warn-unsupported-oidc-client-auth-method
Apr 7, 2026
Merged

feat: Warn when unsupported OIDC client auth method is configured#877
dervoeti merged 5 commits intomainfrom
feat/warn-unsupported-oidc-client-auth-method

Conversation

@dervoeti
Copy link
Copy Markdown
Member

@dervoeti dervoeti commented Apr 7, 2026

Description

Trino does not support configuring the OIDC client authentication method. With the new clientAuthenticationMethod field added to the AuthenticationClass CRD in operator-rs 0.109.0, users could set it without realizing it has no effect.

This PR emits a warning log when a non-default OIDC client authentication method is configured, so users are aware the setting will be ignored.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

razvan
razvan previously approved these changes Apr 7, 2026
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dervoeti dervoeti enabled auto-merge April 7, 2026 14:29
razvan
razvan previously approved these changes Apr 7, 2026
@dervoeti dervoeti added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 4e89eac Apr 7, 2026
12 checks passed
@dervoeti dervoeti deleted the feat/warn-unsupported-oidc-client-auth-method branch April 7, 2026 15:20
@Techassi Techassi moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 8, 2026
@sbernauer sbernauer moved this from Development: Done to Development: In Progress in Stackable Engineering Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants