🤖 Update module github.com/stackitcloud/stackit-sdk-go/services/dns to v0.21.0#157
Conversation
ske-renovate-ce
Bot
added
the
kind/upgrade
ske-prow
Bot
added
the
size/XS
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
ske-prow
Bot
added
size/L
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
| } | ||
|
|
||
| func (c *dnsClient) findRecordSet(ctx context.Context, zoneID, name, recordType string) (*dns.RecordSet, error) { | ||
| func (c *dnsClient) findRecordSet(ctx context.Context, zoneID, name string, recordType *dns.RecordSetType) (*dns.RecordSet, error) { |
There was a problem hiding this comment.
Nit: Is there a reason why dns.RecordSetType is ptr to string? Seems overkill
There was a problem hiding this comment.
Seems easier to just have recordType dns.RecordSetType
There was a problem hiding this comment.
then i have to create an explicit nil check in the other function.
Doing it like so is cleaner since i can do the nil check when i deref the pointer :)
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: d54678438cad8fdaacd5f039af3c6db7eb0b0152 |
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 5091c2c48351691f753f57b6e1e374bb32d52783 |
ske-prow
Bot
added
the
approved
ske-prow
Bot
deleted the
renovate/github.com-stackitcloud-stackit-sdk-go-services-dns-0.x
branch
2 participants
This PR contains the following updates:
v0.20.2→v0.21.0Release Notes
stackitcloud/stackit-sdk-go (github.com/stackitcloud/stackit-sdk-go/services/dns)
v0.21.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.