Remove fork from mcm provider openstack and use newest release#161
Remove fork from mcm provider openstack and use newest release#161viragvoros wants to merge 7 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
size/XS
|
/hold |
ske-prow
Bot
added
the
do-not-merge/hold
|
/cc @stackitcloud/ske-infrastructure |
| sourceRepository: github.com/gardener/machine-controller-manager-provider-openstack | ||
| repository: registry.ske.stackit.cloud/stackitcloud/machine-controller-manager-provider-openstack | ||
| tag: "v0.25.0-ske-1" | ||
| repository: europe-docker.pkg.dev/gardener-project/releases/gardener/machine-controller-manager-provider-openstack |
There was a problem hiding this comment.
do we also need to customize the flag --resource-exhausted-retry that was introduced in that change as well?
There was a problem hiding this comment.
It is an optional flag, for now I added it (I am a bit unsure about the implementation), but we would need to discuss what would be an appropriate retry period for our case.
There was a problem hiding this comment.
I think that is the reason why we contibuted this feature to the machine-controller-manager. It was set in our fork of machine-controller-manager to 30min stackitcloud/machine-controller-manager@a8329dd
There was a problem hiding this comment.
I think we also should set this for the STACKIT MCM because there we also want to avoid recreate everything in case of resource exhausted or?
cc @Kumm-Kai you did the changes in the machine-controller-manager fork. WDYT?
There was a problem hiding this comment.
I'm not sure about the implementation of the STACKIT MCM, do we still create the volume before the server or do we do it in the server create call?
If it's the same as in OpenStack MCM then the flag would be useful otherwise we don't need it, because the STACKIT API wouldn't create the volume when the server cannot be scheduled.
There was a problem hiding this comment.
In the STACKIT MCM we let IaaS create the volume for us. It is just one call that does it all.
ske-prow
Bot
added
size/S
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 92bdada2e1931ef5a325400bdaf9eed6dd8eb84e |
6 participants
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
We want to get rid of the fork for machine-controller-manager-provider-openstack, therefore the necessary changes were contributed upstream. See https://github.com/gardener/machine-controller-manager-provider-openstack/releases/tag/v0.27.0
Which issue(s) this PR fixes:
Special notes for your reviewer: