feat(telemetryrouter): v1api waiters#7492
Conversation
ozanichkovsky
changed the title
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was closed automatically because it has been stalled for 7 days with no activity. Feel free to re-open it at any time. |
| ExpirationTime NullableTime `json:"expirationTime,omitempty"` | ||
| // An auto generated unique id which identifies the access token. | ||
| Id string `json:"id"` | ||
| Status string `json:"status"` |
There was a problem hiding this comment.
We enabled in the meanwhile the generation of inline enums and some of them are missing in this PR. For example the enum for this status field:
Can you update this PR to the latest version of the generated SDK?
| TELEMETRYROUTER_ACTIVE = "active" | ||
| DESTINATION_ACTIVE = "active" | ||
| ACCESSTOKEN_ACTIVE = "active" |
There was a problem hiding this comment.
with the previous comment, this const will be probably obsolete and shouldn't be set here
| ActiveState: []string{TELEMETRYROUTER_ACTIVE}, | ||
| } | ||
|
|
There was a problem hiding this comment.
Please configure here also the ErrorStates. This should be also added for all other waiter
| }, | ||
| DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, |
There was a problem hiding this comment.
Extend it here also with the ErrorState
4 participants
Description
v1api with waiters
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)