Support softmax for row_vector, matrix types + code simplifications#3313
Open
jachymb wants to merge 7 commits intostan-dev:developfrom
Open
Support softmax for row_vector, matrix types + code simplifications#3313jachymb wants to merge 7 commits intostan-dev:developfrom
jachymb wants to merge 7 commits intostan-dev:developfrom
Conversation
Author
|
I think it's some server error, not actual test failure. |
Collaborator
|
EDIT: Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactors the
softmaxandlog_softmaxfunctions in the following ways:vectorandrow_vectorare now supported instead of justvectormatrixtype is also supported and the softmax is applied row-wise. (i.e. the return value is effectively arow_stochastic_matrixfor modelling purposes)Tests
Side Effects
None to my knowledge.
Release notes
softmaxandlog_softmaxnow supportrow_vectorandmatrix(applied row-wise)Checklist
Copyright holder: Me, jachymb@gmail.com
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested