[6.x] New Asset Exists Modal Resolution Feature#14433
Open
jackmcdade wants to merge 16 commits into6.xfrom
Open
[6.x] New Asset Exists Modal Resolution Feature#14433jackmcdade wants to merge 16 commits into6.xfrom
jackmcdade wants to merge 16 commits into6.xfrom
Conversation
Works with uploading and moving assets. Resolves #14381.
This updates the asset conflict UX by making modal-dismiss behavior resolve as cancel, only showing “apply to all” when multiple upload conflicts exist, and replacing recursive move-conflict continuation with an iterative loop. It also adds MoveAsset tests for non-conflicting moves, same-folder no-op moves, and explicit cancel strategy handling.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 29b4b4c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Works with uploading and moving assets. Resolves #14381.
asset-conflicts.mp4
Note
Medium Risk
Touches asset upload/move flows across both CP UI and backend action/controller responses; mistakes could lead to unintended overwrites, skipped moves, or stale cache/metadata behavior.
Overview
Adds a new asset conflict resolution flow for both uploading and moving assets when a filename already exists, prompting users via new CP modals to cancel, keep both (timestamp), or overwrite, with optional apply to all handling.
On the backend,
MoveAssetnow detects destination conflicts and either resolves per strategy (including deleting existing repository entries and clearing Glide cache on overwrite) or returns structured conflict payloads via a newAssetConflictExceptionhandled byActionController; uploads now return a 409 JSON conflict payload fromAssetsController. Frontend upload/move handling is updated to queue conflicts, retry/skip uploads accordingly, support multi-selection drag moves, and bust image caches after overwrite/timestamp resolutions;Asset::movealso now clears the old meta cache key to avoid stale metadata after moves.Reviewed by Cursor Bugbot for commit 73ae1c9. Bugbot is set up for automated code reviews on this repo. Configure here.