Skip to content

style: align outliers with sibling packages in blas/ext/base#11998

Draft
Planeshifter wants to merge 3 commits intodevelopfrom
philipp/fix-commit-review-2026-05-08
Draft

style: align outliers with sibling packages in blas/ext/base#11998
Planeshifter wants to merge 3 commits intodevelopfrom
philipp/fix-commit-review-2026-05-08

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 11fb87da (2026-05-07 13:37 -0500) and 5fd5c85c (2026-05-08 16:47 +0500). Three sibling-consistency fixes across recently-added blas/ext/base packages:

  • blas/ext/base/dindex-of-column — Documentation and interface descriptions in 5fd5c85c use "stride of the first/second dimension" for matrix parameters across lib/dindex_of_column.js, docs/types/index.d.ts, README.md, and src/main.c, deviating from the established "stride length for the" terminology used in sibling packages (dindex-of-row, sindex-of-row, glast-index-of-row, slast-index-of-row) and inconsistent with vector stride language in the same JSDoc blocks. Standardized to "stride length for the" across all parameter descriptions to align with the blas/ext/base convention.

  • blas/ext/base/slast-index-of-row — The error message in lib/slast_index_of_row.js and lib/slast_index_of_row.native.js (03cd59e4) lacks the lower bound specification that sindex-of-row and sibling packages include; updated both files and their JSDoc @throws tags to use the form 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: \%d`.'with both stride andLDA` parameters.

  • blas/ext/base/glast-index-of-row7c02336d has incomplete stride validation messaging in lib/main.js: the runtime throw omits the required lower bound and the @throws tag lacks context. Aligned both the error format string and documentation with the sibling gindex-of-row implementation, which provides the full constraint max(1,N) for auditability.

Related Issues

No related issues.

Questions

No.

Other

Validation

What was checked:

  • stdlib code-style compliance for the four new blas/ext/base packages (cwhere, dindex-of-column, slast-index-of-row, glast-index-of-row) and supporting commits, comparing each against established sibling packages.
  • Bug scan over the diff (loop bounds, stride math, NaN/inf handling, N-API argument validation, row-major vs column-major branching, negative-stride paths, format-string arity, JSDoc/runtime contract agreement).

What was deliberately excluded:

  • Anything requiring interpretation, judgement calls, or context outside the diff window to validate.
  • The auto-generated REPL data dump (ddb2fb7e) and TypeScript declaration auto-updates (cecfaba8, 583a8336) — spot-checked only.
  • Subjective preferences, "could be cleaner" suggestions, and nitpicks.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored end-to-end by Claude Code as part of an automated 24-hour commit-review pass. Findings were produced by parallel reviewer agents, independently re-verified against sibling packages before any edit, and limited to high-signal sibling-consistency fixes. A maintainer should audit before promoting out of draft.


@stdlib-js/reviewers


Generated by Claude Code

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label May 8, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dindex-of-column $\color{green}531/531$
$\color{green}+100.00%$
$\color{green}52/52$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}531/531$
$\color{green}+100.00%$
blas/ext/base/glast-index-of-row $\color{green}555/555$
$\color{green}+100.00%$
$\color{green}56/56$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}555/555$
$\color{green}+100.00%$
blas/ext/base/slast-index-of-row $\color{green}575/575$
$\color{green}+100.00%$
$\color{green}50/50$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}575/575$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title Follow-up fixes for develop commits merged 2026-05-07/2026-05-08 style: align outliers with sibling packages in blas/ext/base May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants