Skip to content

chore(cli-go): migrate Docker SDK to Moby modules#5469

Closed
jgoux wants to merge 1 commit into
dependabot/go_modules/apps/cli-go/github.com/compose-spec/compose-go/v2-2.11.0from
codex/migrate-docker-sdk-moby
Closed

chore(cli-go): migrate Docker SDK to Moby modules#5469
jgoux wants to merge 1 commit into
dependabot/go_modules/apps/cli-go/github.com/compose-spec/compose-go/v2-2.11.0from
codex/migrate-docker-sdk-moby

Conversation

@jgoux
Copy link
Copy Markdown
Contributor

@jgoux jgoux commented Jun 4, 2026

Targets the Dependabot branch for #5461.

compose-go/v2@2.11.0 changed API shapes used by the existing github.com/docker/compose/v2 dependency, which made the Go CLI fail while compiling Docker Compose internals. The earlier helper-only fix avoided that mismatch by removing Compose from image prefetching, but it also moved us away from Compose's pull behavior and progress output.

This migrates the Go CLI Docker integration to the Docker v29 module layout instead: direct Docker client/API imports now use github.com/moby/moby/client and github.com/moby/moby/api, while image prefetching uses github.com/docker/compose/v5. That keeps Compose responsible for parallel pulls and progress display while aligning our code with the public Moby modules documented for Docker v29.

The migration also updates Docker option/result types across the Go CLI, replaces removed Docker utility imports with their Moby equivalents or narrow local test helpers, and removes the old pre-v1.42 volume-prune compatibility branch because Docker v29 no longer targets that API range.

@jgoux jgoux marked this pull request as ready for review June 4, 2026 10:37
@jgoux jgoux requested a review from a team as a code owner June 4, 2026 10:37
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26946441404

Warning

No base build found for commit cd636b4 on dependabot/go_modules/apps/cli-go/github.com/compose-spec/compose-go/v2-2.11.0.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 63.956%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15814
Covered Lines: 10114
Line Coverage: 63.96%
Coverage Strength: 7.13 hits per line

💛 - Coveralls

@jgoux
Copy link
Copy Markdown
Contributor Author

jgoux commented Jun 4, 2026

As this change is quite large, we don't want to take the risk of breaking users workflows before the port is completed. Closing.

@jgoux jgoux closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants