chore(cli-go): migrate Docker SDK to Moby modules#5469
Closed
jgoux wants to merge 1 commit into
Closed
Conversation
Coverage Report for CI Build 26946441404Warning No base build found for commit Coverage: 63.956%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Contributor
Author
|
As this change is quite large, we don't want to take the risk of breaking users workflows before the port is completed. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets the Dependabot branch for #5461.
compose-go/v2@2.11.0changed API shapes used by the existinggithub.com/docker/compose/v2dependency, which made the Go CLI fail while compiling Docker Compose internals. The earlier helper-only fix avoided that mismatch by removing Compose from image prefetching, but it also moved us away from Compose's pull behavior and progress output.This migrates the Go CLI Docker integration to the Docker v29 module layout instead: direct Docker client/API imports now use
github.com/moby/moby/clientandgithub.com/moby/moby/api, while image prefetching usesgithub.com/docker/compose/v5. That keeps Compose responsible for parallel pulls and progress display while aligning our code with the public Moby modules documented for Docker v29.The migration also updates Docker option/result types across the Go CLI, replaces removed Docker utility imports with their Moby equivalents or narrow local test helpers, and removes the old pre-v1.42 volume-prune compatibility branch because Docker v29 no longer targets that API range.