fix(converter): keep x-nullable in shared $ref responses#2276
Merged
ewaostrowska merged 2 commits intoswagger-api:masterfrom Apr 15, 2026
Merged
Conversation
The convert(vendorExtensions) method mutated the original map when filtering out x-nullable, x-example, and x-examples extensions. When multiple endpoints referenced the same response via $ref, the first conversion removed x-nullable from the shared source object, causing subsequent conversions to miss it and produce nullable=null. Create a new map instead of mutating the original to preserve vendor extensions for all endpoints sharing the same response definition.
ewaostrowska
force-pushed
the
bug/2269_fix_lost_xnullable_swagger_2_shared_responses
branch
from
effed28 to
6a32a23
Compare
ewaostrowska
force-pushed
the
bug/2269_fix_lost_xnullable_swagger_2_shared_responses
branch
from
2cd175e to
b2a2fef
Compare
Contributor
|
@esaezgil thank you for providing fix for this issue! Merging it with minor readability improvements and additional test added :) |
ewaostrowska
approved these changes
Apr 15, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
x-nullablevendor extension being lost when multiple endpoints share the same response via$refduring Swagger 2.0 to OpenAPI 3.0 conversionFixes: #2269
Type of Change
Checklist
Screenshots / Additional Context