fix(core): add container logs to TimeoutError when wait strategy times out#1007
Open
ticapix wants to merge 2 commits into
Open
fix(core): add container logs to TimeoutError when wait strategy times out#1007ticapix wants to merge 2 commits into
ticapix wants to merge 2 commits into
Conversation
alexanderankin
approved these changes
May 18, 2026
Member
|
not sure why the cicd is not running 👀 |
Member
|
core/testcontainers/core/container.py:223: error: "TimeoutError" has no |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 83.05% 83.04% -0.02%
==========================================
Files 16 16
Lines 1700 1728 +28
Branches 186 190 +4
==========================================
+ Hits 1412 1435 +23
- Misses 234 236 +2
- Partials 54 57 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for testcontainers !
I had a lot of trouble to understand why my docker strategy was timing out and I ended up patching the code like in this PR to get the container logs when there is a timeout.
I hope it can help others when debugging.
make testsruns okHappy to update the PR if needed