fix(kafka): Use wait strategy instead of deprecated wait_for_logs#903
Merged
alexanderankin merged 3 commits intotestcontainers:mainfrom Apr 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 79.24% 79.24%
=======================================
Files 15 15
Lines 1277 1277
Branches 154 154
=======================================
Hits 1012 1012
Misses 219 219
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hugo-C
changed the title
Hugo-C
force-pushed
the
redpanda-wait-strategy
branch
from
c410486 to
3a67042
Compare
Hugo-C
force-pushed
the
redpanda-wait-strategy
branch
from
3a67042 to
ae1cb02
Compare
Contributor
Author
|
#945 Fixed Kafka but not Redpanda, so I adapted the changes accordingly. |
Contributor
Author
|
@alexanderankin if you can take a look as you merged the similar PR. |
alexanderankin
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #874.
Since those containers first need to be started to know their exposed ports, we cannot use
DockerContainer._wait_strategy. We have to keep checking logs manually in their ownstartmethods.Let me know if there is anything to change.