Conversation
|
We have been discussing these new logos for a long time. Can we get a blessing to make them a part of the TOML project? @pradyunsg @mojombo |
eksortso
left a comment
There was a problem hiding this comment.
This is just to correct a misspelling.
|
Adding only the original vector files should be more than sufficient. Everyone should be able to convert it to the size they need and it prevents committing binary files to a repo (and also ensure there is a single source of truth). |
|
Also some of these icons like logos/monochrome/toml-mark-black-L.png seem to have an improper viewbox showing padding on some sides but not the others. |
Having raster versions of the logo in the repository is a common practice. It helps the quick adoption of the logo in most use cases.
You're right. Thank you for noticing. Let me fix that. |
|
Overall I feel this looks rather nice, but I also find the uneven brackets a bit jarring at e.g. https://github.com/toml-lang/toml/blob/2412ba769caad047ea64ef885eb6f8d23ca4ad3a/README.md The top is a bit shorter than the bottom, and there's a but of an indentation in the top-left and bottom-right one (to "fit" with the T and L). It works quite nice on the small I don't know if that's just me? |
I put the new TOML logos, marks and icons in this PR. Let me know if it works for you.